Garrett Moon
f94229796c
Fixes out of order blocks running on main queue in ASDataController
...
ASDataController’s completedNodes is accessed by treating the main thread as a serial queue. The *problem* is, operations can cut in line by being added while on the main thread. I.e. it just calls the block instead of dispatch_async’ing to the main thread. This results in data inconsistency.
To address this, I've added a queue of operations which get run serially (not to be confused with a serial dispatch queue). Instead of running blocks directly on the main thread, if it’s called while not on the main thread, it dispatch_asyncs to the main thread and runs any blocks in the queue. If it *is* on the main thread, it runs any blocks already in the queue and then runs the block.
2015-12-11 10:45:22 -08:00
Garrett Moon
082dc1cbca
Expose recursivelyEnsureDisplay
2015-12-10 19:42:17 -08:00
appleguy
c9a0a3d46f
Merge pull request #918 from levi/master
...
Inline supplementary kind iteration in data controller
2015-12-07 12:58:25 -08:00
Scott Goodson
88b36f58e7
Ensure an empty array is returned if visibleNodes is called before any nodes are complete.
2015-12-06 21:45:46 -08:00
Levi McCallum
223cac1784
Inline supplementary kind iteration in data controller
2015-12-06 21:31:40 -08:00
appleguy
f6cc2067e9
Merge pull request #917 from levi/master
...
Ensure that newly inserted section supplementary nodes are added to backing store
2015-12-06 21:25:47 -08:00
appleguy
0cf89535d0
Merge pull request #842 from aaronschubert0/ASMapNode
...
[ASMapNode] Initial implementation. Some changes planned, including a replacement initializer method.
2015-12-06 21:07:29 -08:00
Levi McCallum
64da9e7ece
Ensure that new section supplementary nodes are inserted into backing store
2015-12-06 20:07:29 -08:00
Scott Goodson
1e9c4563f3
Improve factoring of locking and early returns for -setInterfaceState: and -setHierarchyState:
2015-12-06 19:30:04 -08:00
Scott Goodson
c11d90cd3a
Fix an issue with ASHierarchyState when disabling rasterization after having enabled it.
2015-12-06 18:46:29 -08:00
Scott Goodson
271f288a19
Polish ASHierarchyState implementation, fix old comment typos, work on test breakages.
2015-12-06 15:04:47 -08:00
Scott Goodson
67aec97523
Adopt ASHierarchyState to replace manual checking for ASCellNode parent.
2015-12-05 22:41:40 -08:00
Scott Goodson
840884272d
Introduced ASHierarchyState. Created ASDisplayNode+FrameworkPrivate.h. Fixed deadlock.
2015-12-05 22:20:16 -08:00
appleguy
29897297c5
Merge pull request #913 from Adlai-Holler/WorkaroundCellContentsLoading
...
Provide Basic Interface State Support for Nodes Outside of Cells
2015-12-05 17:35:28 -08:00
appleguy
faf9d266c5
Merge pull request #914 from Adlai-Holler/UpdateInterfaceStateBeforeCallout
...
Minimize critical section in -setInterfaceState:, and move ivar set before subclass hooks are called.
2015-12-05 16:03:57 -08:00
appleguy
6e13368463
Merge pull request #911 from Adlai-Holler/FixTextNodeHighlightingLogic
...
Reduce Reliance on -textNode:shouldHighlightLinkAttribute:value:atPoint:
2015-12-05 11:01:56 -08:00
Adlai Holler
4284b6e23a
Set _interfaceState before calling fetchData et al.
2015-12-05 00:20:44 -08:00
Adlai Holler
0bfb5a0401
Make new interface state a first-class value
2015-12-04 12:49:38 -08:00
Adlai Holler
9579420cd7
Add static constant ASInterfaceStateInHierarchy which we'll return if the node is not in a cell but its view is in a window
2015-12-04 12:47:36 -08:00
appleguy
3a04cb7cc8
Merge pull request #898 from Adlai-Holler/OptimizeNodeDidRelayout
...
Reduce Frequency of beginUpdates/endUpdates Due to Node Relayout
2015-12-03 21:02:22 -08:00
Adlai Holler
835acd6a25
Change assumed value for text node highlighting delegate method to YES and don't consult it unless highlighting.
2015-12-03 20:52:02 -08:00
Adlai Holler
f39105a8f4
Optimize
2015-12-03 09:45:45 -08:00
Adlai Holler
f723452756
Allow link taps to continue if touches move within the same link
2015-12-03 09:25:37 -08:00
Aaron Schubert
630bd23820
Merge branch 'master' into ASMapNode
2015-12-03 14:22:45 +00:00
Aaron Schubert
79b4c95749
Substantially improved ASMapNode and made it a lot clearer and less complex internally.
2015-12-03 11:22:05 +00:00
appleguy
e42bcf47be
Merge pull request #901 from Adlai-Holler/ModernizeCellLoading
...
ASTableView: Use Fancy dequeueReusableCellWithIdentifier:forIndexPath: Method
2015-12-01 17:54:45 -08:00
Scott Goodson
3b6b48175d
Fix for an incorrect assertion firing when transforming an ASLayoutSpec-positioned node.
2015-12-01 17:49:11 -08:00
Adlai Holler
e1d06e70ff
Fix constant naming
2015-12-01 12:00:38 -08:00
Adlai Holler
ec682db8d7
Fix name
2015-11-30 23:24:57 -08:00
Adlai Holler
1f8df4ffec
Use shiny new dequeueReusableCellWithIdentifier:forIndexPath: method in ASTableView
2015-11-30 23:22:53 -08:00
Adlai Holler
0ee1fd82dc
Refactor nodeDidRelayoutWithSizeChange: -> nodeDidRelayout:sizeChanged:
2015-11-30 19:29:27 -08:00
Adlai Holler
04d93532bc
Only require node sizes once per run loop, and only if a node's size has changed
2015-11-30 17:20:32 -08:00
Levi McCallum
04ad021daa
Rename positioning block to sport as namespace
2015-11-30 06:55:32 -08:00
Levi McCallum
cd78bcce99
Convert naming of hash helpers to AS namespace
2015-11-30 06:53:50 -08:00
Levi McCallum
2cf4b22c96
Include correct TextKit headers
2015-11-30 06:46:53 -08:00
Levi McCallum
c1f4456fd5
Use composed attributed truncation string for underlying drawing text
2015-11-30 06:44:53 -08:00
Levi McCallum
a8e6aebe9c
Remove public header exposure of text kit internals
2015-11-30 06:44:53 -08:00
Levi McCallum
397e5b15e9
Fix tabbing on initializer
2015-11-30 06:44:53 -08:00
Levi McCallum
a0c05ebffc
Rename CK classes to AS classes
2015-11-30 06:44:53 -08:00
Levi McCallum
de66819286
Implement functioning isTruncated API on ASTextNode
2015-11-30 06:41:41 -08:00
Levi McCallum
74435fb584
Convert ASTextNode to support CKTextKitRenderer
2015-11-30 06:41:41 -08:00
Levi McCallum
275fd3eddd
Include missing hash helpers implementation
2015-11-30 06:41:40 -08:00
Levi McCallum
bae3e3b63d
Add latest ComponentKit text kit renderer into project
2015-11-30 06:41:40 -08:00
appleguy
937b72b64a
Merge pull request #879 from levi/levi/custom-layout-example
...
Add custom collection view layout example project
2015-11-29 22:14:31 -08:00
appleguy
171160564a
Merge pull request #895 from Adlai-Holler/Cleanup894
...
Cleanup PR 894
2015-11-29 22:01:04 -08:00
Levi McCallum
24cb1d5cb0
Fix broken build
2015-11-29 21:49:34 -08:00
appleguy
d132416d90
Merge pull request #848 from nguyenhuy/JustifyContentSpaceBetweenAndAround
...
Implement "space between" and "space around" justify content options for stack layout
2015-11-29 21:46:42 -08:00
Levi McCallum
c801965f94
Zero out constrained size value by default
2015-11-29 21:28:59 -08:00
Adlai Holler
fca8614c18
Scope like a boss
2015-11-29 21:22:37 -08:00
Adlai Holler
50b318b117
Lock and unlock manually when doing early return
2015-11-29 17:49:11 -08:00
