Adlai Holler
a53c8a3c34
Improve error handling in ASMultiplexImageNode
2015-10-14 11:00:56 -07:00
Adlai Holler
b09d6a3602
Demote Photos.framework image requests to UserInitiated quality of service
2015-10-13 21:22:03 -07:00
Adlai Holler
fbd3c77fec
Finish that thought
2015-10-11 08:43:43 -07:00
Adlai Holler
d964364cd5
Add some documentation in DataController, plus use Fast Enumeration more
2015-10-11 08:39:29 -07:00
Adlai Holler
595891629c
Remove pointless assertion
2015-10-10 10:33:56 -07:00
Adlai Holler
0c361894ac
Remove comment
2015-10-09 21:17:11 -07:00
Adlai Holler
1e232561f4
Whitespace
2015-10-09 21:16:28 -07:00
Adlai Holler
0eb3490363
Finish removing needsMeasure
2015-10-09 21:15:32 -07:00
Adlai Holler
7f42b37dec
Remove needsMeasure
2015-10-09 21:13:00 -07:00
Adlai Holler
0848aac186
Revert prior change
2015-10-09 20:28:42 -07:00
Adlai Holler
d8e99e00bd
Remove public needsMeasure
2015-10-09 20:27:38 -07:00
Adlai Holler
fdb11275db
Put back the frame-setting behavior when measuring cell nodes
2015-10-09 20:23:54 -07:00
Adlai Holler
06b7897bc1
Finish measuring on main thread when possible
2015-10-09 20:06:59 -07:00
Adlai Holler
93cdc0f2f5
Don't set cell node frames during measurement
2015-10-09 19:55:14 -07:00
Adlai Holler
223e9ff504
Merge branch 'DontSetCellNodeFramesDuringMeasure' into MeasureCellNodesOnMain
...
Conflicts:
AsyncDisplayKit/Details/ASDataController.mm
2015-10-09 19:53:46 -07:00
Adlai Holler
e716ccb580
Don't set cell node frames during measure, set them just before returning the cell size to UITableView/UICollectionView
2015-10-09 19:51:12 -07:00
Adlai Holler
e92a6ce9e3
Initial work on measuring loaded cell nodes on the main thread
2015-10-09 19:37:36 -07:00
appleguy
ca5780f6f4
Merge pull request #714 from Adlai-Holler/WorkaroundPhotosDeadlock
...
Workaround Photos.framework deadlock by locking
2015-10-07 17:20:52 -07:00
Scott Goodson
a8435b494c
Revert "Properly support operating with nil asyncDelegate for Table & Collection."
...
This reverts commit 77745c55b084c51d57a405073a6e9b00c379f918.
Bug was found / reported in https://github.com/facebook/AsyncDisplayKit/issues/721
Attempting resolution here, but need to fix for current clients now:
https://github.com/facebook/AsyncDisplayKit/pull/724
2015-10-07 14:48:37 -07:00
Huy Nguyen
c2fbd651da
Lock the property lock in ASDisplayNode __setSafeFrame
2015-10-07 22:21:43 +03:00
Huy Nguyen
8b7dc916f8
Fix indentations in ASDisplayNode:layout
2015-10-07 22:16:37 +03:00
Huy Nguyen
5a2fea7c1d
Use bounds and position to layout subnodes, instead of frame because it is not safe in case the transform property constains a non-identity transform.
2015-10-07 21:54:48 +03:00
Adlai Holler
cb407367be
Cancel image requests in ASMultiplexImageNode.clearFetchedData
2015-10-07 10:08:54 -07:00
Adlai Holler
cdfd5c1fdd
Check whether data source responds to asset method
2015-10-07 10:08:28 -07:00
ricky cancro
89a216b90d
Fixes to baseline stack alignment
...
1) Set the ascender/descender of an ASTextNode when the attributeString is set. Previously ascender/descender were only being computed in `setValuesFromLayoutable` and only when the attribute string was not nil. May make sense to remove the computation from `setValuesFromLayoutable` entirely.
2) Remove ability to allow different children of a stack spec to aling to different baselines. This wasn't working before and I'm not convinced it is possible to do properly/useful enough to invest the time.
3) Have all stack spec run `ASStackBaselinePositionedLayout::compute` to compute the stack's ascender and descender. Even if the stack isn't aligning its children to a baseline, the stack itself may be a child of another stack that IS aligning to a baseline.
2015-10-06 21:41:39 -07:00
Adlai Holler
6d73cee9fd
Give ASMultiplexImageNodeDataSources an opportunity to provide PHAssets quicker
2015-10-06 16:35:50 -07:00
appleguy
e41f7c59c4
Merge pull request #717 from levi/scrollnode-initializer
...
Use long-form view block initializer for better Swift support
2015-10-06 15:26:31 -07:00
appleguy
ed7f2274f9
Merge pull request #711 from garrettmoon/addSupportForDisablingAndEnablingShouldRasterize
...
Adds support for disabling and re-enabling should rasterize.
2015-10-06 13:36:54 -07:00
appleguy
656fbeb526
Merge pull request #706 from facebook/NilDelegate
...
Properly support operating with nil asyncDelegate for Table & Collection.
2015-10-06 13:35:23 -07:00
Adlai Holler
fffc76a353
Have ASMultiplexImageNode store its image request operation weakly
2015-10-06 13:21:42 -07:00
Garrett Moon
8a70c8d416
Adds support for disabling and re-enabling should rasterize.
2015-10-06 11:47:13 -07:00
Levi McCallum
1f799a6687
Use long-form view block initializer for better Swift support
2015-10-06 09:34:57 -07:00
Adlai Holler
1801620094
Make ASTextNode copy exclusionPaths and attributedString
2015-10-06 00:46:20 -07:00
Adlai Holler
ae3eb70f6a
Public API fast paths in ASTextNode
2015-10-06 00:40:33 -07:00
Adlai Holler
87caed27e2
Add more deep compares when setting public properties to the same value
2015-10-05 23:48:48 -07:00
Adlai Holler
f0b7e150cd
Limit 1 inflight Photos.framework request per multiplex image node
2015-10-05 23:40:33 -07:00
Adlai Holler
d94dcdef0f
Only do PHAsset metadata requests one at a time to workaround Photos framework deadlock
2015-10-05 23:40:33 -07:00
Adlai Holler
ce97b56580
Sugar
2015-10-05 20:41:21 -07:00
Adlai Holler
c5b5bdd29c
Use deep compare when setting image identifiers in ASMultiplexImageNode
2015-10-05 20:34:42 -07:00
Garrett Moon
b1d03f1d58
Address comments
2015-10-05 16:02:01 -07:00
Garrett Moon
d6c107a896
Fix shouldRasterizeSubnodes skipping setting offset and clipping.
2015-10-05 16:02:01 -07:00
Adlai Holler
99b9f73b1a
Fix index into size ranges
2015-10-05 11:51:05 -07:00
Adlai Holler
33c07db58c
Set node.frame entirely
2015-10-05 11:42:25 -07:00
Adlai Holler
4601fccb5a
Optimize ASDataController._layoutNodes
2015-10-05 11:37:29 -07:00
Scott Goodson
77745c55b0
Properly support operating with nil asyncDelegate for Table & Collection.
2015-10-04 17:11:41 -07:00
appleguy
67cf6d3951
Merge pull request #705 from facebook/ThreadAffinity
...
Improved messages for thread affinity and frame transform identity assertions.
2015-10-04 16:24:39 -07:00
Scott Goodson
61bb4f022e
Improved messages for thread affinity and frame transform identity assertions.
2015-10-04 11:15:57 -07:00
appleguy
057422d52b
Merge pull request #699 from rcancro/staticLayout
...
Fix static layout to ensure it always considers its sub layout's preferred sizes.
2015-10-04 10:52:02 -07:00
ricky cancro
eb5e670e5d
wasn't copying alignSelf
2015-10-02 20:58:52 -07:00
appleguy
897f7210ad
Merge pull request #687 from Adlai-Holler/AdvancedPhotos
...
Advanced Photos Integration
2015-10-02 16:40:58 -07:00
