appleguy 6799e26b03 [ASTextNode2] Upgrade lock safety by protecting all ivars (including rarely-changed ones). (#918) ...

* [ASTextNode2] Upgrade lock safety by protecting all ivars (including rarely-changed ones).

Although I don't know of any specific crashes caused by this, I think we should
lock all properties by default. There are also some indications of premature
optimization in keeping lock scope small, where it is actually important to
have transactional integrity, and also where the ASDisplayNode base class is
otherwise going to repeatedly re-lock the object anyway.

I think this will remain pretty efficient, especially with os_unfair_lock enabled.

* Use compare-assign macros

2018-05-19 12:47:06 -07:00

..

Base

#trivial Fix the C++ assertion (#911)

2018-05-07 15:28:48 -07:00

Debug

Use NS_RETURNS_RETAINED macro to save time (#843)

2018-03-21 08:13:09 -07:00

Details

[ASTextNode2] Upgrade lock safety by protecting all ivars (including rarely-changed ones). (#918)

2018-05-19 12:47:06 -07:00

Layout

Make objects conform to NSLocking (#851)

2018-03-25 10:46:04 -07:00

Private

Add experiment to skip creating UIViews altogether for constants (#881)

2018-04-12 10:14:29 -07:00

TextKit

Prevent UITextView from updating contentOffset while deallocating (#915)

2018-05-09 08:30:03 -07:00

tvOS

[tvOS] Fixes errors when building against tvOS SDK (#728)

2018-03-11 16:37:27 -07:00

_ASTransitionContext.h

Use NS_RETURNS_RETAINED macro to save time (#843)

2018-03-21 08:13:09 -07:00

_ASTransitionContext.m

Use NS_RETURNS_RETAINED macro to save time (#843)

2018-03-21 08:13:09 -07:00

ASBlockTypes.h

Fix "This block and function declaration is not a prototype" warning. (#619)

2017-10-17 14:18:23 +01:00

ASButtonNode.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASButtonNode.mm

Make objects conform to NSLocking (#851)

2018-03-25 10:46:04 -07:00

ASCellNode.h

[ASWrapperCellNode] Introduce a new class allowing more control of UIKit passthrough cells. (#797)

2018-03-13 01:03:18 -07:00

ASCellNode.mm

[ASWrapperCellNode] Introduce a new class allowing more control of UIKit passthrough cells. (#797)

2018-03-13 01:03:18 -07:00

ASCGImageBuffer.h

[NoCopyRendering] In non-VM case, use calloc to get a zerod buffer. (#869)

2018-04-04 13:32:23 -07:00

ASCGImageBuffer.m

[NoCopyRendering] In non-VM case, use calloc to get a zerod buffer. (#869)

2018-04-04 13:32:23 -07:00

ASCollectionNode.h

[ASWrapperCellNode] Introduce a new class allowing more control of UIKit passthrough cells. (#797)

2018-03-13 01:03:18 -07:00

ASCollectionNode.mm

[ASWrapperCellNode] Introduce a new class allowing more control of UIKit passthrough cells. (#797)

2018-03-13 01:03:18 -07:00

ASCollectionNode+Beta.h

[ASWrapperCellNode] Introduce a new class allowing more control of UIKit passthrough cells. (#797)

2018-03-13 01:03:18 -07:00

ASCollectionView.h

[ASWrapperCellNode] Introduce a new class allowing more control of UIKit passthrough cells. (#797)

2018-03-13 01:03:18 -07:00

ASCollectionView.mm

[ASCollectionNode/ASTableNode] Fix a crash occurs while remeasuring cell nodes (#917)

2018-05-15 20:18:54 +01:00

ASCollectionViewLayoutFacilitatorProtocol.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASCollectionViewProtocols.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASConfiguration.h

Create a centralized configuration API (#747)

2018-03-25 12:52:57 -07:00

ASConfiguration.m

Create a centralized configuration API (#747)

2018-03-25 12:52:57 -07:00

ASConfigurationDelegate.h

Create a centralized configuration API (#747)

2018-03-25 12:52:57 -07:00

ASConfigurationInternal.h

Introduce ASRecursiveUnfairLock and tests (#858)

2018-03-28 11:29:50 -07:00

ASConfigurationInternal.m

Call out to delegate for control users in experiments (#923)

2018-05-16 08:33:28 -07:00

ASContextTransitioning.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASControlNode.h

[tvOS] Fixes errors when building against tvOS SDK (#728)

2018-03-11 16:37:27 -07:00

ASControlNode.mm

Make objects conform to NSLocking (#851)

2018-03-25 10:46:04 -07:00

ASControlNode+Subclasses.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASDisplayNode.h

[ASDisplayNode] Provide safeAreaInsets and layoutMargins bridge (#685)

2018-03-27 14:29:17 +01:00

ASDisplayNode.mm

Improve thread-safety of ASDisplayNode's didExitHierarchy #trivial (#916)

2018-05-11 17:26:00 +01:00

ASDisplayNode+Beta.h

[ASDisplayNode] Consolidate main thread initialization and allow apps to invoke it manually instead of +load. (#798)

2018-02-25 22:15:40 -08:00

ASDisplayNode+Convenience.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASDisplayNode+Convenience.m

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASDisplayNode+Layout.mm

Make objects conform to NSLocking (#851)

2018-03-25 10:46:04 -07:00

ASDisplayNode+Subclasses.h

Replace pthread specifics with C11 thread-local variables (#811)

2018-02-28 12:42:30 -08:00

ASDisplayNode+Yoga.mm

Make objects conform to NSLocking (#851)

2018-03-25 10:46:04 -07:00

ASDisplayNodeExtras.h

[Minor Breaking API] Make deallocation queues more reliable (#651)

2017-11-02 10:45:34 -07:00

ASDisplayNodeExtras.mm

[bugfix] Align timing of interface coalescing and range update. #trivial (#847)

2018-04-04 08:01:12 -07:00

ASEditableTextNode.h

SEP-491 prerequisite: add textViewShouldBeginEditing: to ASEditableTextNodeDelegate (#535)

2017-08-28 19:49:41 +01:00

ASEditableTextNode.mm

[ASTextKitComponents] Make sure Main Thread Checker isn't triggered during background calculations #trivial (#612)

2017-10-17 14:20:20 +01:00

ASExperimentalFeatures.h

Update configuration schema (#893)

2018-05-05 09:48:19 -07:00

ASExperimentalFeatures.m

Issue ASNetworkImageNode callbacks off main thread (#908)

2018-05-04 12:21:42 -07:00

ASImageNode.h

[tvOS] Fixes errors when building against tvOS SDK (#728)

2018-03-11 16:37:27 -07:00

ASImageNode.mm

Make objects conform to NSLocking (#851)

2018-03-25 10:46:04 -07:00

ASImageNode+AnimatedImage.mm

Fixes an issue where playback may not start (#896)

2018-05-02 09:34:53 -07:00

ASMapNode.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASMapNode.mm

Make objects conform to NSLocking (#851)

2018-03-25 10:46:04 -07:00

ASMultiplexImageNode.h

Use NS_RETURNS_RETAINED macro to save time (#843)

2018-03-21 08:13:09 -07:00

ASMultiplexImageNode.mm

Make objects conform to NSLocking (#851)

2018-03-25 10:46:04 -07:00

ASNavigationController.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASNavigationController.m

Overhaul our logging, add activity tracing support. (#399)

2017-07-03 19:03:26 -07:00

ASNetworkImageLoadInfo.h

Create a centralized configuration API (#747)

2018-03-25 12:52:57 -07:00

ASNetworkImageLoadInfo.m

Create a centralized configuration API (#747)

2018-03-25 12:52:57 -07:00

ASNetworkImageNode.h

[#trivial] fixes rendered image quality on networked image nodes which have their image directly set. (#826)

2018-03-08 16:21:54 -08:00

ASNetworkImageNode.mm

Issue ASNetworkImageNode callbacks off main thread (#908)

2018-05-04 12:21:42 -07:00

ASNodeController+Beta.h

[ASDisplayNode] Consolidate main thread initialization and allow apps to invoke it manually instead of +load. (#798)

2018-02-25 22:15:40 -08:00

ASNodeController+Beta.m

[ASDisplayNode] Consolidate main thread initialization and allow apps to invoke it manually instead of +load. (#798)

2018-02-25 22:15:40 -08:00

ASPagerFlowLayout.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASPagerFlowLayout.m

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASPagerNode.h

[Cleanup] Remove deprecated APIs (#529)

2017-09-07 19:25:42 +01:00

ASPagerNode.m

[ASCollectionNode][ASTableNode] Add content inset bridging property (#560)

2017-09-11 19:20:32 +01:00

ASPagerNode+Beta.h

[ASCollectionLayout] Add ASCollectionGalleryLayoutSizeProviding (#451)

2017-07-18 10:08:12 +00:00

ASRangeManagingNode.h

Make Cell Node Properties Atomic (#74)

2017-05-02 14:09:12 -07:00

ASRunLoopQueue.h

Create a centralized configuration API (#747)

2018-03-25 12:52:57 -07:00

ASRunLoopQueue.mm

Create a centralized configuration API (#747)

2018-03-25 12:52:57 -07:00

ASScrollNode.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASScrollNode.mm

Make objects conform to NSLocking (#851)

2018-03-25 10:46:04 -07:00

ASSectionController.h

Remove References to IGListSectionType, Now that It's Gone (#49)

2017-04-26 13:04:03 -07:00

ASSupplementaryNodeSource.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASTabBarController.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASTabBarController.m

Overhaul our logging, add activity tracing support. (#399)

2017-07-03 19:03:26 -07:00

ASTableNode.h

[ASWrapperCellNode] Introduce a new class allowing more control of UIKit passthrough cells. (#797)

2018-03-13 01:03:18 -07:00

ASTableNode.mm

[ASWrapperCellNode] Introduce a new class allowing more control of UIKit passthrough cells. (#797)

2018-03-13 01:03:18 -07:00

ASTableNode+Beta.h

[Batch Fetching] Add ASBatchFetchingDelegate (#281)

2017-05-17 13:26:30 +01:00

ASTableView.h

[ASWrapperCellNode] Introduce a new class allowing more control of UIKit passthrough cells. (#797)

2018-03-13 01:03:18 -07:00

ASTableView.mm

[ASCollectionNode/ASTableNode] Fix a crash occurs while remeasuring cell nodes (#917)

2018-05-15 20:18:54 +01:00

ASTableViewInternal.h

Make Cell Node Properties Atomic (#74)

2017-05-02 14:09:12 -07:00

ASTableViewProtocols.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASTextNode2.h

[ASTextNode2] Upgrade lock safety by protecting all ivars (including rarely-changed ones). (#918)

2018-05-19 12:47:06 -07:00

ASTextNode2.mm

[ASTextNode2] Upgrade lock safety by protecting all ivars (including rarely-changed ones). (#918)

2018-05-19 12:47:06 -07:00

ASTextNode.h

Create a centralized configuration API (#747)

2018-03-25 12:52:57 -07:00

ASTextNode.mm

[ASTextNode] Check variables before calling delegate method #trivial (#898)

2018-05-11 17:24:26 +01:00

ASTextNode+Beta.h

Create a centralized configuration API (#747)

2018-03-25 12:52:57 -07:00

ASTextNodeCommon.h

Create a centralized configuration API (#747)

2018-03-25 12:52:57 -07:00

ASVideoNode.h

added error reporting callback to ASVideoNode (#260)

2017-05-11 12:23:12 +01:00

ASVideoNode.mm

Make objects conform to NSLocking (#851)

2018-03-25 10:46:04 -07:00

ASVideoPlayerNode.h

[Cleanup] Remove deprecated APIs (#529)

2017-09-07 19:25:42 +01:00

ASVideoPlayerNode.mm

Make objects conform to NSLocking (#851)

2018-03-25 10:46:04 -07:00

ASViewController.h

[ASDisplayNode] Provide safeAreaInsets and layoutMargins bridge (#685)

2018-03-27 14:29:17 +01:00

ASViewController.mm

[ASDisplayNode] Provide safeAreaInsets and layoutMargins bridge (#685)

2018-03-27 14:29:17 +01:00

ASVisibilityProtocols.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

ASVisibilityProtocols.m

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

AsyncDisplayKit.h

Introduce ASRecursiveUnfairLock and tests (#858)

2018-03-28 11:29:50 -07:00

AsyncDisplayKit.modulemap

Fix failing build in XCode 8.3 (#3241)

2017-04-04 14:37:45 -07:00

AsyncDisplayKit+IGListKitMethods.h

Remove References to IGListSectionType, Now that It's Gone (#49)

2017-04-26 13:04:03 -07:00

AsyncDisplayKit+IGListKitMethods.m

Remove References to IGListSectionType, Now that It's Gone (#49)

2017-04-26 13:04:03 -07:00

IGListAdapter+AsyncDisplayKit.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

IGListAdapter+AsyncDisplayKit.m

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

Info.plist

Shuffle & Cleanup Stuff (#3080)

2017-02-26 18:14:13 -08:00

UIImage+ASConvenience.h

[ASDKFastImageNamed] Fixes nullability of UIImage initializers (#897)

2018-04-28 08:19:37 -07:00

UIImage+ASConvenience.m

Use NS_RETURNS_RETAINED macro to save time (#843)

2018-03-21 08:13:09 -07:00

UIResponder+AsyncDisplayKit.h

Update license v2 (#67)

2017-04-24 16:59:57 -07:00

UIResponder+AsyncDisplayKit.m

Update license v2 (#67)

2017-04-24 16:59:57 -07:00