ThePain/Swiftgram
1
0
Fork 0
mirror of https://github.com/Swiftgram/Telegram-iOS.git synced 2026-01-21 03:29:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #440 from bitstadium/fix/use-copy-for-NSString

Browse Source 
Use copy attribute for properties of type NSString
This commit is contained in:
Benjamin Scholtysik (Reimold)
2017-07-25 19:05:15 -07:00
committed by GitHub
parent a398b986d7 de5414b683
commit d2a014bc66
18 changed files with 40 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Classes/BITAuthenticator.h
View File

@@ -230,7 +230,7 @@ typedef NS_ENUM(NSUInteger, BITAuthenticatorAppRestrictionEnforcementFrequency)
* @see identificationType
* @see handleOpenURL:sourceApplication:annotation:
*/
@property (nonatomic, strong) NSString *urlScheme;
@property (nonatomic, copy) NSString *urlScheme;
/**
Should be used by the app-delegate to forward handle application:openURL:sourceApplication:annotation: calls.

18
Classes/BITCrashDetails.h
View File

@@ -36,27 +36,27 @@
/**
* UUID for the crash report
*/
@property (nonatomic, readonly, strong) NSString *incidentIdentifier;
@property (nonatomic, readonly, copy) NSString *incidentIdentifier;
/**
* UUID for the app installation on the device
*/
@property (nonatomic, readonly, strong) NSString *reporterKey;
@property (nonatomic, readonly, copy) NSString *reporterKey;
/**
* Signal that caused the crash
*/
@property (nonatomic, readonly, strong) NSString *signal;
@property (nonatomic, readonly, copy) NSString *signal;
/**
* Exception name that triggered the crash, nil if the crash was not caused by an exception
*/
@property (nonatomic, readonly, strong) NSString *exceptionName;
@property (nonatomic, readonly, copy) NSString *exceptionName;
/**
* Exception reason, nil if the crash was not caused by an exception
*/
@property (nonatomic, readonly, strong) NSString *exceptionReason;
@property (nonatomic, readonly, copy) NSString *exceptionReason;
/**
* Date and time the app started, nil if unknown
@@ -71,14 +71,14 @@
/**
* Operation System version string the app was running on when it crashed.
*/
@property (nonatomic, readonly, strong) NSString *osVersion;
@property (nonatomic, readonly, copy) NSString *osVersion;
/**
* Operation System build string the app was running on when it crashed
*
* This may be unavailable.
*/
@property (nonatomic, readonly, strong) NSString *osBuild;
@property (nonatomic, readonly, copy) NSString *osBuild;
/**
* CFBundleShortVersionString value of the app that crashed
@@ -86,12 +86,12 @@
* Can be `nil` if the crash was captured with an older version of the SDK
* or if the app doesn't set the value.
*/
@property (nonatomic, readonly, strong) NSString *appVersion;
@property (nonatomic, readonly, copy) NSString *appVersion;
/**
* CFBundleVersion value of the app that crashed
*/
@property (nonatomic, readonly, strong) NSString *appBuild;
@property (nonatomic, readonly, copy) NSString *appBuild;
/**
* Identifier of the app process that crashed

4
Classes/BITCrashManager.m
View File

@@ -187,8 +187,8 @@ __attribute__((noreturn)) static void uncaught_cxx_exception_handler(const BITCr
@property (nonatomic, strong) NSMutableDictionary *approvedCrashReports;
@property (nonatomic, strong) NSMutableArray *crashFiles;
@property (nonatomic, strong) NSString *settingsFile;
@property (nonatomic, strong) NSString *analyzerInProgressFile;
@property (nonatomic, copy) NSString *settingsFile;
@property (nonatomic, copy) NSString *analyzerInProgressFile;
@property (nonatomic) BOOL crashIdenticalCurrentVersion;
@property (nonatomic) BOOL sendingInProgress;
@property (nonatomic) BOOL isSetup;

4
Classes/BITCrashManagerPrivate.h
View File

@@ -68,12 +68,12 @@
@property (nonatomic, copy, setter = setAlertViewHandler:) BITCustomAlertViewHandler alertViewHandler;
@property (nonatomic, strong) NSString *crashesDir;
@property (nonatomic, copy) NSString *crashesDir;
#if HOCKEYSDK_FEATURE_AUTHENTICATOR
// Only set via BITAuthenticator
@property (nonatomic, strong) NSString *installationIdentification;
@property (nonatomic, copy) NSString *installationIdentification;
// Only set via BITAuthenticator
@property (nonatomic) BITAuthenticatorIdentificationType installationIdentificationType;

2
Classes/BITFeedbackActivity.h
View File

@@ -70,6 +70,6 @@
@see customActivityImage
*/
@property (nonatomic, strong) NSString *customActivityTitle;
@property (nonatomic, copy) NSString *customActivityTitle;
@end

2
Classes/BITFeedbackComposeViewController.m
View File

@@ -57,7 +57,7 @@
@property (nonatomic, strong) UIButton *addPhotoButton;
@property (nonatomic, strong) NSString *text;
@property (nonatomic, copy) NSString *text;
@property (nonatomic, strong) NSMutableArray *attachments;
@property (nonatomic, strong) NSMutableArray *imageAttachments;

2
Classes/BITFeedbackManager.m
View File

@@ -62,7 +62,7 @@ typedef void (^BITLatestImageFetchCompletionBlock)(UIImage *_Nonnull latestImage
@interface BITFeedbackManager () <UIGestureRecognizerDelegate>
@property (nonatomic, strong) NSFileManager *fileManager;
@property (nonatomic, strong) NSString *settingsFile;
@property (nonatomic, copy) NSString *settingsFile;
@property (nonatomic, weak) id appDidBecomeActiveObserver;
@property (nonatomic, weak) id appDidEnterBackgroundObserver;
@property (nonatomic, weak) id networkDidBecomeReachableObserver;

2
Classes/BITFeedbackManagerPrivate.h
View File

@@ -58,7 +58,7 @@ extern NSString *const kBITFeedbackUpdateAttachmentThumbnail;
@property (nonatomic, strong) NSMutableArray *feedbackList;
@property (nonatomic, strong) NSString *token;
@property (nonatomic, copy) NSString *token;
// used by BITHockeyManager if disable status is changed

4
Classes/BITFeedbackMessageAttachment.m
View File

@@ -43,8 +43,8 @@
@property (nonatomic, strong) NSMutableDictionary *thumbnailRepresentations;
@property (nonatomic, strong) NSData *internalData;
@property (nonatomic, copy) NSString *filename;
@property (nonatomic, strong) NSString *tempFilename;
@property (nonatomic, strong) NSString *cachePath;
@property (nonatomic, copy) NSString *tempFilename;
@property (nonatomic, copy) NSString *cachePath;
@property (nonatomic, strong) NSFileManager *fm;
@end

4
Classes/BITHockeyAttachment.h
View File

@@ -40,7 +40,7 @@
/**
The filename the attachment should get
*/
@property (nonatomic, readonly, strong) NSString *filename;
@property (nonatomic, readonly, copy) NSString *filename;
/**
The attachment data as NSData object
@@ -50,7 +50,7 @@
/**
The content type of your data as MIME type
*/
@property (nonatomic, readonly, strong) NSString *contentType;
@property (nonatomic, readonly, copy) NSString *contentType;
/**
Create an BITHockeyAttachment instance with a given filename and NSData object

2
Classes/BITHockeyBaseManagerPrivate.h
View File

@@ -35,7 +35,7 @@
@interface BITHockeyBaseManager()
@property (nonatomic, strong) NSString *appIdentifier;
@property (nonatomic, copy) NSString *appIdentifier;
@property (nonatomic, assign, readonly) BITEnvironment appEnvironment;

2
Classes/BITHockeyManager.h
View File

@@ -226,7 +226,7 @@ NS_ASSUME_NONNULL_BEGIN
@warning This property needs to be set before calling `startManager`
*/
@property (nonatomic, strong) NSString *serverURL;
@property (nonatomic, copy) NSString *serverURL;
#if HOCKEYSDK_FEATURE_CRASH_REPORTER

4
Classes/BITHockeyManager.m
View File

@@ -81,8 +81,8 @@ static bitstadium_info_t bitstadium_library_info __attribute__((section("__TEXT,
- (BOOL)shouldUseLiveIdentifier;
@property (nonatomic, strong) NSString *appIdentifier;
@property (nonatomic, strong) NSString *liveIdentifier;
@property (nonatomic, copy) NSString *appIdentifier;
@property (nonatomic, copy) NSString *liveIdentifier;
@property (nonatomic) BOOL validAppIdentifier;
@property (nonatomic) BOOL startManagerIsInvoked;
@property (nonatomic) BOOL startUpdateManagerIsInvoked;

2
Classes/BITPersistencePrivate.h
View File

@@ -37,7 +37,7 @@ FOUNDATION_EXPORT NSString *const BITPersistenceSuccessNotification;
*/
@property (nonatomic, assign) NSUInteger maxFileCount;
@property (nonatomic, strong) NSString *appHockeySDKDirectoryPath;
@property (nonatomic, copy) NSString *appHockeySDKDirectoryPath;
/**
* An array with all file paths, that have been requested by the sender. If the sender

2
Classes/BITStoreUpdateManager.h
View File

@@ -120,7 +120,7 @@ typedef NS_ENUM(NSInteger, BITStoreUpdateSetting) {
@see checkForUpdateOnLaunch
@see checkForUpdate
*/
@property (nonatomic, strong) NSString *countryCode;
@property (nonatomic, copy) NSString *countryCode;
/**

6
Classes/BITStoreUpdateManager.m
View File

@@ -40,9 +40,9 @@
@interface BITStoreUpdateManager ()
@property (nonatomic, strong) NSString *latestStoreVersion;
@property (nonatomic, strong) NSString *appStoreURLString;
@property (nonatomic, strong) NSString *currentUUID;
@property (nonatomic, copy) NSString *latestStoreVersion;
@property (nonatomic, copy) NSString *appStoreURLString;
@property (nonatomic, copy) NSString *currentUUID;
@property (nonatomic) BOOL updateAlertShowing;
@property (nonatomic) BOOL lastCheckFailed;
@property (nonatomic, weak) id appDidBecomeActiveObserver;

12
Classes/BITUpdateManager.m
View File

@@ -54,14 +54,14 @@ typedef NS_ENUM(NSInteger, BITUpdateAlertViewTag) {
@interface BITUpdateManager ()
@property (nonatomic, strong) NSString *currentAppVersion;
@property (nonatomic, copy) NSString *currentAppVersion;
@property (nonatomic) BOOL dataFound;
@property (nonatomic) BOOL showFeedback;
@property (nonatomic) BOOL updateAlertShowing;
@property (nonatomic) BOOL lastCheckFailed;
@property (nonatomic, strong) NSFileManager *fileManager;
@property (nonatomic, strong) NSString *updateDir;
@property (nonatomic, strong) NSString *usageDataFile;
@property (nonatomic, copy) NSString *updateDir;
@property (nonatomic, copy) NSString *usageDataFile;
@property (nonatomic, weak) id appDidBecomeActiveObserver;
@property (nonatomic, weak) id appDidEnterBackgroundObserver;
@property (nonatomic, weak) id networkDidBecomeReachableObserver;
@@ -69,9 +69,9 @@ typedef NS_ENUM(NSInteger, BITUpdateAlertViewTag) {
@property (nonatomic) BOOL didEnterBackgroundState;
@property (nonatomic) BOOL firstStartAfterInstall;
@property (nonatomic, strong) NSNumber *versionID;
@property (nonatomic, strong) NSString *versionUUID;
@property (nonatomic, strong) NSString *uuid;
@property (nonatomic, strong) NSString *blockingScreenMessage;
@property (nonatomic, copy) NSString *versionUUID;
@property (nonatomic, copy) NSString *uuid;
@property (nonatomic, copy) NSString *blockingScreenMessage;
@property (nonatomic, strong) NSDate *lastUpdateCheckFromBlockingScreen;
@end

6
Classes/BITUpdateManagerPrivate.h
View File

@@ -74,11 +74,11 @@
@property (nonatomic, strong) UIView *blockingView;
@property (nonatomic, strong) NSString *companyName;
@property (nonatomic, copy) NSString *companyName;
@property (nonatomic, strong) NSString *installationIdentification;
@property (nonatomic, copy) NSString *installationIdentification;
@property (nonatomic, strong) NSString *installationIdentificationType;
@property (nonatomic, copy) NSString *installationIdentificationType;
@property (nonatomic) BOOL installationIdentified;