Gareth Reese
3fee0810d5
[ASVideoNode] Ensure that both ASVideoNode and ASNetworkImageNode delegate methods are called for ASVideoNode observers
2016-06-21 11:36:54 +01:00
Hannah Troisi
c857e809f4
Clean up header comments (for consistent Facebook licensing info) ( #1741 )
...
[Licensing] Clean up header comments (for consistent Facebook licensing info)
2016-06-11 23:31:39 -07:00
Luke Parham
fc5467b110
fixed typo and added backwards compatibility for 'visibilityDidChange'
2016-06-06 02:02:23 -05:00
Luke Parham
e510120031
changed '-visibilityDidChange:' to '-visiblieStateDidChange:' to match the others
2016-06-06 00:56:21 -05:00
Hannah Troisi
52d58992da
[ASVideoNode] Change superclass to ASNetworkImageNode so that it can be its own placeholder ( #1710 )
...
* [ASVideoNode] Change superclass to ASNetworkImageNode so that ASVideoNode can be its own placeholder
- remove _placeholderImageNode property of ASVideoNode (use self.image now instead)
- move layoutSpecThatFits: code to calculateSizeThatFits: & layout: methods as ASImageNode uses calculateSizeThatFits:
* [ASVideoNode] Tweaks to the definition of the delegate protocols to integrate with ASNetworkImageNode (superclass)
2016-06-05 18:18:52 -07:00
Erekle
100d2b4f26
moved spinner to ASVIdeoPlayerNode
2016-05-19 15:07:39 +04:00
Erekle
98c451118b
removed play button
...
* Removed play button from ASVideoNode
* Removed play button tests
* added some checks in ASVideoPlayerNode
* added new delegate method for time formats
2016-05-13 00:46:55 +04:00
Robin Chou
39ee33f21a
Update remaining tests.
2016-04-28 21:13:34 -04:00
Robin Chou
9c2909a968
Updating tests.
2016-04-28 21:04:04 -04:00
Eric Jensen
6a4bc3fd5b
Rename setPlaceholderImage to setVideoPlaceholderImage in order to prevent super class setter conflict
2016-04-18 22:30:32 -07:00
Eric Jensen
b5c3b15069
Observe playbackLikelyToKeepUp in order to handle player buffer filling and emptying
2016-04-18 22:13:49 -07:00
Eric Jensen
e65d63a502
Simplified and improved video node's handling of state changes:
...
- Simplified visibility state change handling.
- Placeholder image is now updated after switching assets.
- Improves memory usage by clearing the placeholder image in clearFetchedData.
2016-04-18 22:13:49 -07:00
Eric Jensen
c1c1358baf
Fix video stalling by pausing the video after backgrounding the application
2016-04-18 13:53:43 -07:00
Eric Jensen
983c2f1f49
Replacing ASVideoNode's playButton now cleans-up the previous button's state
2016-04-18 13:53:43 -07:00
Eric Jensen
cdb926c0a1
Correct mismatch between video gravity and placeholder image content mode
2016-04-18 13:53:43 -07:00
Scott Goodson
11744b7f31
[ASVideoNode] Cleanup from recent diffs, standardizing on .asset rather than .url.
2016-04-17 20:12:37 -07:00
Gareth Reese
9e28e07925
ASVideoNode updates based on review comments in https://github.com/facebook/AsyncDisplayKit/pull/1323
2016-04-07 14:08:45 +01:00
Gareth Reese
c8a414be9b
Merged branch 'master' into AVPlayerItem-construction
2016-04-06 15:22:10 +01:00
Luke Parham
be463c0a17
muting the video node mutes the player
2016-04-05 02:37:07 -05:00
Hannah Troisi
f9a92366d3
[AsyncDisplayKit] Fix build so we can weak link AVFoundation
...
Unclear why the framework target required these seemingly unrelated changes to Collection
classes, but I modeled them after related files and it seems cleaner now (passes tests & framework target)
2016-03-19 17:54:02 -07:00
Scott Goodson
abd148ae2e
[Testing] ASVideoNodeTests should not pass in an invalid combination of ASInterfaceState flags.
2016-03-15 17:25:47 -07:00
Gareth Reese
f7ff8b4173
Updated tests to cover the new API and repeated all of the test logic for URL initialisation to ensure that the functionality is the same
2016-03-08 08:30:13 +00:00
Eric Jensen
cb1579e8af
Check the AVAsset's type before casting to an AVURLAsset
2016-02-26 11:00:27 -08:00
Luke Parham
2313b32406
removed comment
2016-01-29 16:31:54 -08:00
Luke Parham
98fb2e46d4
wip but currently adding first frame as placeholder until it should play and removed extraneous 'pause'
2016-01-24 23:13:17 -06:00
Luke Parham
d9559111a0
renamed nic cage sample, added redundancy for loading player in case its nil when visible, added video tests, disabled assert for new range controller
2016-01-14 02:39:36 -06:00
Luke Parham
6dc15ffd44
added delegate method for video did finish, moved layer creation to after view displays, rearranged spinner logic, added tests
2015-12-22 15:34:11 -06:00
Luke Parham
4602e4e9eb
wip fixing pr comments
2015-12-22 02:15:25 -06:00
Luke Parham
c69e18bc6e
refactored test
2015-12-19 00:14:17 -06:00
Luke Parham
901a8fbd98
fixed video tests
2015-12-18 04:47:26 -06:00
Luke Parham
b5c1076921
wip, adding play button functionality
2015-12-16 23:02:39 -06:00
