3123 Commits

Author SHA1 Message Date
appleguy
23faa99b40 Merge pull request #1555 from vivqu/support_ios7
Update ASSentinel to use OSAtomicAdd32 to support iOS7.0
2016-04-19 12:01:02 -07:00
Michael Schneider
3793dc024e Improve setting special properties for certain classes directly to the UIView
- Remove duplicated code in ASCollectionNode and ASTableNode
- Fix setting the pending state to the view if applying the pending state to the view
2016-04-19 10:50:22 -07:00
Vivian Qu
ccb5860c78 Update ASSentinel to use OSAtomicAdd32 to support iOS7.0 2016-04-19 10:46:55 -07:00
Aaron Schubert
21abe8f899 Fix merge conflicts 2016-04-19 09:02:07 +01:00
Eric Jensen
a49d620771 Replace dispatch_async(dispatch_get_main_queue... with ASPerformBlockOnMainThread 2016-04-18 23:08:57 -07:00
Eric Jensen
6a4bc3fd5b Rename setPlaceholderImage to setVideoPlaceholderImage in order to prevent super class setter conflict 2016-04-18 22:30:32 -07:00
Eric Jensen
a2b03d6e90 Change ASContentModeFromVideoGravity's default to UIViewContentModeScaleAspectFit 2016-04-18 22:13:49 -07:00
Eric Jensen
b5c3b15069 Observe playbackLikelyToKeepUp in order to handle player buffer filling and emptying 2016-04-18 22:13:49 -07:00
Eric Jensen
e65d63a502 Simplified and improved video node's handling of state changes:
- Simplified visibility state change handling.
- Placeholder image is now updated after switching assets.
- Improves memory usage by clearing the placeholder image in clearFetchedData.
2016-04-18 22:13:49 -07:00
appleguy
33e36de5dc Merge pull request #1552 from chourobin/feature/hls
[ASVideoNode] Re-enables HLS support
2016-04-18 22:09:43 -07:00
appleguy
f9d00eea93 Merge pull request #1550 from maicki/FixArrayDiffStaticAnalyzer
[NSArray+Diffing] Static analyzer issue with common indexes algorithm in _asdk_commonIndexesWithArray:
2016-04-18 22:01:29 -07:00
appleguy
8d0fe9650b Merge pull request #1549 from ejensen/video-fixes-rebase
[ASVideoNode] Several small bug fixes, improved code quality, added more tests.
2016-04-18 21:56:57 -07:00
Hannah Troisi
2658cf429e Merge remote-tracking branch 'facebook/master' 2016-04-18 21:06:56 -07:00
Robin Chou
bdd4baf933 Re-enables HLS support (can't use AVAsset for HTTP live stream media). 2016-04-18 22:38:47 -04:00
Michael Schneider
8d20321d67 Fix ASTableNode / ASCollectionNode backgroundColor does not work
If the background color is applied via the pending state it's applied to the layer of the UICollectionView / UITableview. Unfortunately UITableView / UICollectionView does not consider using the layer backgroundColor property as it's background color, so it needs to be applied to the view after the ASCollectionNode / ASTableNode did load and the view is available
2016-04-18 15:52:22 -07:00
Michael Schneider
9d07336c75 Fix static analyzer issue with common indexes algorithm in _asdk_commonIndexesWithArray:
The issue was: The left operand of '>=' is a garbage value in else if check for lengths[i+1][j] ... I had to rewrite the algorithm to quiet the static analyzer.
2016-04-18 14:38:32 -07:00
Eric Jensen
c1c1358baf Fix video stalling by pausing the video after backgrounding the application 2016-04-18 13:53:43 -07:00
Eric Jensen
983c2f1f49 Replacing ASVideoNode's playButton now cleans-up the previous button's state 2016-04-18 13:53:43 -07:00
Eric Jensen
cdb926c0a1 Correct mismatch between video gravity and placeholder image content mode 2016-04-18 13:53:43 -07:00
Eric Jensen
651a6bb3e4 Add nullability annotations and documentation comments to ASVideoNode 2016-04-18 13:53:43 -07:00
appleguy
103506beec Merge pull request #1534 from hannahmbanana/mapSnapshotBug
[ASMapNode] Defer snapshots triggered before layout occurs to reduce unnecessary snapshots.
2016-04-18 13:34:56 -07:00
Hannah Troisi
4395af015d Removing _site files that accidently snuck into commit. 2016-04-18 10:12:58 -07:00
Hannah Troisi
1b3ca72877 Fix preexisting code - missing super call 2016-04-17 22:49:14 -07:00
appleguy
2a1617d80c Merge pull request #1545 from facebook/Video
[ASVideoNode] Cleanup from recent diffs, standardizing on .asset rather than .url.
2016-04-17 22:08:17 -07:00
Hannah Troisi
1ff07b2233 Changed comment for clarity. 2016-04-17 21:53:01 -07:00
Scott Goodson
cd25facda5 [Build] Addressing some linker warnings in the test target. 2016-04-17 21:07:35 -07:00
Hannah Troisi
354b972e73 Renamed instance variable & improved comment per request 2016-04-17 20:45:50 -07:00
appleguy
322d85e738 Merge pull request #1511 from maicki/ASLayoutSpecOptimizations
[ASLayoutSpec] Improvements for ASLayoutSpec's internal implementation of child / children properties.
2016-04-17 20:26:54 -07:00
appleguy
9c26ebdec9 Merge pull request #1524 from ejensen/node-traversal-nullability
[ASDisplayNodeExtras] Include __kindof in nullability annotations for hierarchy traversal methods.
2016-04-17 20:20:17 -07:00
Scott Goodson
53d010b055 [ASVideoNode, Build / Framework] Ensure ASVideoNode.mm is in the framework target. 2016-04-17 20:16:53 -07:00
Scott Goodson
11744b7f31 [ASVideoNode] Cleanup from recent diffs, standardizing on .asset rather than .url. 2016-04-17 20:12:37 -07:00
appleguy
94d0d908dc Merge pull request #1323 from gazreese/AVPlayerItem-construction
[ASVideoNode] Add support for HTTP Live Streaming Video
2016-04-17 19:30:23 -07:00
appleguy
30a0c471ca Merge pull request #1528 from ejensen/instancetype
[Refactoring] Replace id with instancetype in initializers
2016-04-16 20:53:41 -07:00
appleguy
c51907879d Merge pull request #1530 from hannahmbanana/500pxgram
[ASDKgram example update] Use -fetchData in PhotoCellNode to load Comments & addressed PR comments
2016-04-16 20:48:32 -07:00
appleguy
d38145a5ab Merge pull request #1540 from maicki/FixProjectPodspecC++Flag
[Build] Fix podspec vs xcodeproj inconsistency with c++ build flag
2016-04-16 16:56:07 -07:00
appleguy
954ea7597f Merge pull request #1538 from nguyenhuy/remove_ASDisplayNodeExtraIvars
[ASDisplayNode][Refactoring] Remove ASDisplayNodeExtraIvars
2016-04-16 16:54:49 -07:00
appleguy
46fbc6cc7c Merge pull request #1539 from nguyenhuy/remove_ASDisplayNode_async_sizing
[ASDisplayNode][Refactoring] Remove internal and unused async sizing methods
2016-04-16 16:53:55 -07:00
Aaron Schubert
5897c1e1b4 [ASMapNode] Remove false assert. This handles #1534 2016-04-16 13:19:07 +01:00
appleguy
fcdc7966cc Merge pull request #1536 from garrettmoon/upstream-renderer-lock
[ASTextNode] Add locking around NSTextContainer's constrainedSize
2016-04-15 20:57:32 -07:00
appleguy
254ac7e24c Merge pull request #1527 from maicki/FixTrailingRectDeadlock
[ASTextNode] Fix deadlock calling trailingRect
2016-04-15 20:54:11 -07:00
Michael Schneider
9c525179ec Fix podspec vs xcodeproj inconsistency with the c++ build flag 2016-04-15 13:24:08 -07:00
Huy Nguyen
5a677915ba ASDisplayNode should bail early if a scheduled transition was invalidated before its block executes
- Idea borrowed from _enqueueAsyncSizingWithSentinel
2016-04-15 22:08:48 +03:00
Huy Nguyen
a35647b200 Remove unused _enqueueAsyncSizingWithSentinel and asyncSizingQueue methods of ASDisplayNode 2016-04-15 22:08:21 +03:00
Huy Nguyen
3dc2ceb0ad Remove ASDisplayNodeExtraIvars 2016-04-15 21:48:11 +03:00
Garrett Moon
dd998b086f I think this needs a lock.
Summary: Looks like this isn't being locked when it should be.

Reviewers: ricky, levi, scottg, schneider

Reviewed By: scottg, schneider

Subscribers: jenkins

Differential Revision: https://phabricator.pinadmin.com/D84952
2016-04-15 10:41:31 -07:00
Michael Schneider
c0927f8028 Create helper function to get text range rects without locking
Add helper function that should be called within performBlockWithLockedTextKitComponents: in
 an already locked state to prevent a deadlock
2016-04-15 09:57:24 -07:00
Michael Schneider
9fdce828c1 Small improvements for ASLayoutSpec
- Add nullable for returning children
- Store default child and children as properties
- Use vector for creating final children
2016-04-15 07:11:24 -07:00
Michael Schneider
a9d0542d8f If trailing rect was set early return 2016-04-15 07:10:22 -07:00
Michael Schneider
91b6995987 Fix deadlock calling trailingRect on a ASTextNode 2016-04-15 07:10:22 -07:00
appleguy
402c5fe25a Merge pull request #1485 from garrettmoon/addAnimatedImage
[ASImageNode] Add support for animated GIFs, planning for future animated formats as well.
2016-04-15 00:05:43 -07:00