Eric Jensen
17aebcbaba
Add a space between the ? and : in ternarys
2016-03-17 10:38:51 -07:00
appleguy
d9ef0922d8
Merge pull request #1354 from ejensen/cleanup
...
[Refactoring] Objective-C 2.0 / Modern syntax for arrays, dictionaries, numbers; logic simplification
2016-03-17 01:06:33 -07:00
Eric Jensen
33fda7ab49
- Use modern Objective-C syntax.
...
- Simplify comparisons.
- Remove dead stores.
2016-03-15 22:34:29 -07:00
Eric Jensen
ddd5ff1f75
Correct spelling errors
2016-03-15 21:56:51 -07:00
appleguy
a4e3ba49b4
Merge pull request #1349 from levi/patch-8
...
[ASDimension / ASSizeRange] Add ASSizeRangeMakeExactSize method
2016-03-11 21:21:09 -08:00
Huy Nguyen
fa8f2f4429
Implement async transition
2016-03-11 18:56:58 -08:00
Levi McCallum
52391dcc27
Change method name in implementation
2016-03-09 10:42:56 -08:00
Levi McCallum
a07f7b73f0
Change method name in header
2016-03-09 10:42:35 -08:00
Levi McCallum
d4a0c34d86
Add ASSizeRangeMakeWithExactCGSize method
2016-03-09 10:39:46 -08:00
Levi McCallum
167b7d404e
Add header for extern ASSizeRangeMakeWithExactCGSize
2016-03-09 10:38:25 -08:00
Garrett Moon
6d9720bd18
Wrong name in header
2016-02-20 17:33:29 -08:00
Levi McCallum
5cf5cb8452
Delegate layout frame calculation to sublayout method
2016-02-10 11:44:12 -08:00
Levi McCallum
8cdea808ec
Expose calculated frame on layout
2016-02-10 11:44:11 -08:00
Levi McCallum
8238da8d00
Fix node deletion and flatten identification issues
2016-02-10 11:44:11 -08:00
Levi McCallum
51977ed162
Identify flattened layouts to allow filtering of non-hierarchy nodes
2016-02-10 11:44:11 -08:00
Levi McCallum
561ae212d9
Wrap implicit hierarchy management in a class enable bit
2016-02-01 17:49:47 -08:00
Levi McCallum
184d1fc059
Switch layout flatten to BFS for node ordering
2016-02-01 17:49:47 -08:00
Scott Goodson
0feaa2a368
Improvements to the efficiency of recursivelySetInterfaceState: and the beta range controller.
2016-01-10 02:40:47 -08:00
Scott Goodson
44feece701
Implement node-backing for ASTableView and ASCollectionView, with a strong back-pointer in these cases.
2015-12-26 23:05:34 -08:00
Scott Goodson
a2cf2a88e6
Overhaul header files / includes to eliminate circular references that Xcode 7 is angry about.
2015-12-25 19:22:00 -08:00
Scott Goodson
882d4b336e
Merge branch 'master' into pr/664
2015-12-25 14:32:41 -08:00
Scott Goodson
27c151095b
[ASPagerNode] New API tweaks. Support setting delegate + dataSource on ASCollectionNode and ASTableNode without triggering view creation.
2015-12-24 17:06:57 -08:00
Adlai Holler
69767d558e
Merge branch 'master' into update-objc
...
Conflicts:
AsyncDisplayKit/Private/ASDisplayNode+FrameworkPrivate.h
2015-12-22 00:28:21 -05:00
Scott Goodson
c6759671e6
Merge branch 'master' into RemoveWorkingWindow
2015-12-18 18:25:14 -08:00
appleguy
bc6e5fee1a
Merge pull request #949 from rcancro/roundMin
...
Do not round when resolving relative dimensions
2015-12-17 15:34:12 -08:00
rcancro
c6f4aff4ef
Do not round when resolving relative dimensions
...
When laying out a node I got to a point where the constrained width was min 132.22222pts and max width was 100%. When resolving the relative size to pts it rounded to 132pt. This caused an assert in ASSizeRangeMake because the min width (132.222pt) was bigger than the max width (132pt)
2015-12-17 15:20:40 -08:00
rcancro
71c44843c8
enforce pixels bounds for ASLayout size/position
2015-12-16 13:14:33 -08:00
Adlai Holler
1fd65c2f25
Annotate ASAsciiArtBoxCreator.h
2015-12-01 21:57:45 -08:00
Adlai Holler
fdfe18873a
Merge branch 'master' into update-objc
...
Conflicts:
AsyncDisplayKit/ASDisplayNodeExtras.h
AsyncDisplayKit/Details/ASTextNodeRenderer.h
AsyncDisplayKit/Details/ASTextNodeShadower.h
2015-12-01 16:45:25 -08:00
Scott Goodson
7f59beb195
Initial experimental commit with functioning preloading, without the working window.
2015-11-30 19:01:57 -08:00
Levi McCallum
a0c05ebffc
Rename CK classes to AS classes
2015-11-30 06:44:53 -08:00
appleguy
d132416d90
Merge pull request #848 from nguyenhuy/JustifyContentSpaceBetweenAndAround
...
Implement "space between" and "space around" justify content options for stack layout
2015-11-29 21:46:42 -08:00
Huy Nguyen
0077c3eec6
Implement horizontal and vertical alignments for stack layout
2015-11-24 20:57:19 +02:00
Huy Nguyen
1162e02b06
Implement "space between" and "space around" options of stack layout justify content
2015-11-16 19:34:08 +02:00
Huy Nguyen
390d16caef
Quickly return min size if a stack has no children
2015-11-16 01:46:28 +02:00
Adlai Holler
762be97a51
Merge branch 'master' into update-objc
2015-11-13 12:03:30 -08:00
Scott Goodson
6d8bad13c0
Fix crash in ASCII art creator for one-element children arrays
2015-11-08 19:04:16 -08:00
Adlai Holler
b4b88da8cd
Merge branch 'master' into update-objc
...
Conflicts:
AsyncDisplayKit/ASCellNode.h
2015-11-02 09:36:46 -08:00
Samuel Hsiung
29a12834b0
adds convenience methods to return a vertical and horizontal stack spec
2015-10-29 20:06:46 -07:00
Adlai Holler
8e104f4887
Merge branch 'master' into update-objc
...
Conflicts:
AsyncDisplayKit/ASCollectionView.h
AsyncDisplayKit/ASDisplayNode.h
AsyncDisplayKit/Details/ASDataController.h
AsyncDisplayKit/Details/UIView+ASConvenience.h
AsyncDisplayKit/Layout/ASLayoutSpec.h
2015-10-28 21:10:27 -07:00
rcancro
050160e6bb
fixed the build again (removed all generic collections)
2015-10-19 10:04:49 -07:00
rcancro
f164b97700
Put all ascii box methods into a Debugging category.
2015-10-19 08:32:14 -07:00
rcancro
3b983c5a50
Ascii art for layoutables
2015-10-16 16:15:29 -07:00
Adlai Holler
b1e60a95e6
Merge branch 'master' into update-objc
2015-10-13 21:26:20 -07:00
ricky cancro
89a216b90d
Fixes to baseline stack alignment
...
1) Set the ascender/descender of an ASTextNode when the attributeString is set. Previously ascender/descender were only being computed in `setValuesFromLayoutable` and only when the attribute string was not nil. May make sense to remove the computation from `setValuesFromLayoutable` entirely.
2) Remove ability to allow different children of a stack spec to aling to different baselines. This wasn't working before and I'm not convinced it is possible to do properly/useful enough to invest the time.
3) Have all stack spec run `ASStackBaselinePositionedLayout::compute` to compute the stack's ascender and descender. Even if the stack isn't aligning its children to a baseline, the stack itself may be a child of another stack that IS aligning to a baseline.
2015-10-06 21:41:39 -07:00
Adlai Holler
8bb9d173dc
Merge branch 'master' into update-objc
...
Conflicts:
AsyncDisplayKit/ASDisplayNode+Subclasses.h
AsyncDisplayKit/ASMultiplexImageNode.h
AsyncDisplayKit/ASViewController.h
AsyncDisplayKit/Details/ASDataController.h
2015-10-05 13:24:16 -07:00
appleguy
057422d52b
Merge pull request #699 from rcancro/staticLayout
...
Fix static layout to ensure it always considers its sub layout's preferred sizes.
2015-10-04 10:52:02 -07:00
ricky cancro
eb5e670e5d
wasn't copying alignSelf
2015-10-02 20:58:52 -07:00
ricky cancro
45a555cdb5
Static layout bug?
...
I noticed when creating a static layout that the sizeRange of the children was being ignored. The case was:
I had an image as a child of a static layout
The image was set to have an exact range of 90x90
When the static layout was measured, the constrained size came in as 375xInf (the width of the containing node and unbounded)
The static layout computed its final size as 375x90
According to the comments in component kit's header file the static layout "[c]omputes a size that is the union of all childrens' frames." It appeared that we are only doing that in the unbounded direction. My fix is to do it in both directions.
2015-10-02 15:56:31 -07:00
Adlai Holler
37e2a530ad
Merge branch 'master' into update-objc
2015-09-19 12:53:06 -07:00