Commit Graph

25012 Commits

Author SHA1 Message Date
Garrett Moon
04ed52f995 [Documentation] Improve ASTableView docs. (#2316)
* Improve ASTableView docs.

* Matching ASCollectionView style.
2016-10-04 18:17:23 -04:00
Adlai Holler
ba2e12010b [ASCollectionView] Only remeasure all nodes if bounds changed in a fixed dimension (#2343) 2016-10-04 18:12:34 -04:00
Benjamin Scholtysik (Reimold)
bc897354c2 Add string resources back to CrashOnlyLib in podspec 2016-10-04 11:33:49 -07:00
Benjamin Scholtysik (Reimold)
8d0a7c2ae3 Fix unit test for app icon logic 2016-10-04 11:15:31 -07:00
Benjamin Scholtysik (Reimold)
02a73fb08b a tiny update to the changelog. 2016-10-04 10:23:33 -07:00
ricky
872aad220f [ASTextKitFontSizeAdjuster] Use the constrainedSize’s height to adjust font scaling (#2309)
* refactor shrinking logic

# Conflicts:
#	AsyncDisplayKit/TextKit/ASTextKitFontSizeAdjuster.mm

* fix ASTraitCollection sample

* updated comments.

* fix build errors

* adlai’s comments
2016-10-04 13:01:50 -04:00
Michael Schneider
d6e5e27c39 [Layout] Add helper properties for setting sizes via CGSize and ASRelativeSize (#2324)
* Remove set layout style size helper

* Update API to set and get a CGSize / ASRelativeSize from an ASLayoutElementStyle

- Expose ASRelativeSize type
- Add new helper properties to set a size / relative size to ASLayoutElementStyle
- Don't expose the size in ASLayoutElementStyle anymore and move into ASLayoutElementStylePrivate

* Update examples

* Update comments for size helpers
2016-10-04 12:35:45 -04:00
Adlai Holler
f027a8be80 Remove ASSentinel (#2336) 2016-10-04 12:22:16 -04:00
appleguy
360541fac5 [ASDisplayNode] Change _pendingDisplayNodes from NSMutableSet to ASWeakSet. (#2340)
In at least some cases, _pendingDisplayNodes referencing self can cause the
object to live longer than the application needs, while tearing down views.

It also appears there may be a cancellation condition where this state is
not balanced properly, which can cause a reference-cycle leak.  This change
safely fixes this problem when tested against a repro case for it.

I'm filing a followup task to make sure all cancellation edge cases have
proper accounting for this codepath, even though the leak is fixed.
2016-10-04 10:22:54 -04:00
Benjamin Scholtysik (Reimold)
49f2417069 Bump versions to 4.1.2 2016-10-03 18:00:22 -07:00
Adlai Holler
67045c07b8 Handle nil node blocks gracefully in production (#2338) 2016-10-03 20:06:13 -04:00
Adlai Holler
0a2e35af38 [ASCollectionView] Allow User to Submit Updates Before Initial Data Load (#2337)
* Add tests for how UICV/ASCV will throw if you update before the initial data load

* Allow user to submit updates before initial data load to workaround UICollectionView bug

* Add some info
2016-10-03 19:13:50 -04:00
Garrett Moon
5205ef6840 [API] Remove old deprecated methods. (#2312)
* Remove old deprecated methods. Will restore ones that were removed recently based on PR.

* Update example to use non-deprecated method.

* Don't remove locking / unlocking, insets or willDisplayNode deprecated methods yet.
2016-10-03 14:57:01 -04:00
Scott Goodson
a25f4a7b85 Revert "[ASCellNode] Fix applyLayoutAttributes not called, add readonly layoutAttributes property (#2321)"
This reverts commit f9ee1dd4b6.

This appears to have caused a test failure:
https://travis-ci.org/facebook/AsyncDisplayKit/jobs/164532435
2016-10-02 19:36:06 -07:00
Scott Goodson
7fc9f1824a Force xcpretty 0.2.2 instead of new 0.2.3 release that is failing on Travis. 2016-10-02 19:18:20 -07:00
Huy Nguyen
066351bad7 Introduce ASSectionContext and ASSection (#2178)
- Objects conform to ASSectionContext protocol can be provided via ASCollectionDataSource and later retrieved from the collection view. They are guaranteed to be in sync with sections of the collection view. They can be used to store additional data associated with each section, to be used in collection view layout and the like.
- ASSection is an internal object that is the foundation for coming debugging tools.
- Unit tests included.
2016-10-01 14:04:05 -04:00
Benjamin Scholtysik (Reimold)
04d82254ad Merge remote-tracking branch 'origin/develop' into release/4.1.2 2016-09-30 19:04:26 -07:00
Benjamin Scholtysik (Reimold)
f2a9e747ae Fix warning caused by Plcrashreporter 1.3 update 2016-09-30 19:03:21 -07:00
Benjamin Scholtysik (Reimold)
4d8935b0ff Merge pull request #352 from bitstadium/feature/cleanup-framework-structure
Feature/cleanup framework structure
2016-09-30 19:00:27 -07:00
Benjamin Scholtysik (Reimold)
22d29226f4 Update info about plcrashreporter 2016-09-30 18:57:44 -07:00
Benjamin Scholtysik (Reimold)
10daa93ac3 Update PlCrashReporter to 1.3 2016-09-30 18:43:35 -07:00
Benjamin Scholtysik (Reimold)
ac2e7bc6fe Bump version number and fix podspec resource paths. 2016-09-30 18:42:41 -07:00
Benjamin Scholtysik (Reimold)
c561b36c13 Merge remote-tracking branch 'origin/develop' into feature/cleanup-framework-structure 2016-09-30 17:50:19 -07:00
Benjamin Scholtysik (Reimold)
72dce51e8b Update all of our build scripts. 2016-09-30 17:49:41 -07:00
Benjamin Scholtysik (Reimold)
624c2bca0b Merge pull request #351 from bitstadium/fix/fix-static-analyser-warnings
Fixing the analyzer warnings
2016-09-30 17:35:37 -07:00
Benjamin Scholtysik (Reimold)
c261e88bbd Simplify build configurations. 2016-09-30 11:15:47 -07:00
Hannah Troisi
3f42fcbc7d check button state before changing` (#2323) 2016-09-29 21:22:23 -07:00
Benjamin Scholtysik (Reimold)
3bf3773709 Fixing the analyzer warnings 2016-09-29 18:53:29 -07:00
Benjamin Scholtysik (Reimold)
6fd36a62f1 Merge pull request #339 from outlook/feature/update-alert
Check if update alert should be shown with update manager delegate
2016-09-29 16:23:46 -07:00
Benjamin Scholtysik (Reimold)
c081a7a962 Merge pull request #349 from bitstadium/fix/update-readme
Update readme with paragraph about custom measurements and properties
2016-09-29 16:19:12 -07:00
Michael Schneider
4692e25204 Add allowsGroupOpacity property to ASDisplayNode (#2320) 2016-09-29 14:30:05 -07:00
Adlai Holler
f9ee1dd4b6 [ASCellNode] Fix applyLayoutAttributes not called, add readonly layoutAttributes property (#2321) 2016-09-29 16:41:28 -04:00
Hannah Troisi
47f73576ef [Layout] Rename ASStackLayoutable to ASStackLayoutElement (#2322)
* redo all renaming, push new branch

* rename a few missed occurances of static
2016-09-29 12:29:21 -07:00
Hannah Troisi
7551627b58 [Layout] Rename ASLayoutable to ASLayoutElement (#2290)
* [Layout API] Rename ASLayoutable to ASLayoutElement

* arg

* fix wrapperWithLayoutElement

* [Layout API] Rename ASLayoutable to ASLayoutElement

* arg

* address Michael's comments

* Remove ASLayoutValidation files that were deleted on master since this diff was created.
2016-09-29 00:02:47 -07:00
Michael Schneider
1abc1a833c Remove legacy layout validation code (#2311) 2016-09-28 16:46:31 -07:00
Peter
2b964b14a7 no message 2016-09-29 02:04:35 +03:00
Garrett Moon
5cd8f28ad5 @return is recognized by the syntax highlighter. (#2313) 2016-09-28 14:40:05 -07:00
Michael Schneider
4aa7c9631d Disable ASTextKitRenderer cache (#2315) 2016-09-28 16:42:06 -04:00
Peter
f8d06dc399 no message 2016-09-28 23:41:53 +03:00
Hannah Troisi
87595c7d3b [Layout API] Rename ASStaticLayoutSpec to ASAbsoluteLayoutSpec (#2288)
* Rename static to absolute

* Fix examples, rename ASAbsoluteLayoutSpec class method

* rename +staticLayoutSpecWithChildren to +absoluteLayoutSpecWithChildren

* address Michael's comments
2016-09-28 13:05:31 -04:00
Adlai Holler
37d9d401b3 [ASDisplayNode] Failing Test Case: Rasterized Nodes Should Get Interface State Updates (#2242)
* Add new failing test cases for dealloc-while-visible

* Disable the new tests for the time being
2016-09-27 19:54:52 -04:00
Michael Schneider
2f99951732 [Layout] Move [ASLayoutSpec children] from std::map to NSMutableArray (#2253)
* Initial commit to move [ASLayoutSpec children] from std::map to NSMutableArray

* Add NSFastEnumeration to ASLayoutable

* ASNullLayoutSpec is a Singleton now

* Move ASLayoutSpecPrivate in Private folder

* Move to NSArrayPointer and remove ASNullLayoutSpec

* Revert "Move to NSArrayPointer and remove ASNullLayoutSpec"

This reverts commit 9ab9cf7024b1f6e1984d84fe58af2b84e84cdf94.

* Move to childAtIndex: and setChild:atIndex:
2016-09-27 19:41:45 -04:00
Adlai Holler
8a4d4e3b5c Simplify/optimize rounded image generation (#2292) 2016-09-27 18:42:46 -04:00
Michael Schneider
e85583523f [Layout] Add support for flex factor (#2298)
* Add support for flex factor

* Add snapshot tests

* Respect child specified size from ASLayoutable

* Add new snapshot test images

* Fix rebase conflict
2016-09-27 18:39:50 -04:00
Adlai Holler
f421787cd3 Add some nullability specifiers to our public headers (#2291) 2016-09-27 18:15:04 -04:00
Adlai Holler
ec64b9b229 [ASDataController] Call All Completion Handlers after Nested Batch Updates (#2274)
* Add tests for batch update completion handler calling

* Ensure we call all completion handlers after collection view updates

* Tweak it

* Fix the doc

* Minor improvements

* Document addCompletionHandler better
2016-09-27 17:21:28 -04:00
Michael Schneider
416d8f92e1 [Layout] Add delegate to ASLayoutableStyle for property changes (#2283)
* Add delegate to ASLayoutableStyle for property changes

* Moving ASLayoutableStyle delegate to readonly

* Add ASLayoutableStyleTests

* Fix property stirngs

* Fix video example

* Address comments of Adlai
2016-09-27 16:50:36 -04:00
Michael Schneider
f574f2c54e [Layout] Further deprecation steps for preferredFrameSize (#2255)
* Deprecate preferredFrameSize

- Remove all support for preferredFrameSize in ASDK
- preferredFrameSize setter calls through and sets the width and height of the node
- preferredFrameSize getter tries to return a CGSize based on the width and height properties otherwise if this is not possible it throws

* Address comments

* Return CGSizeZero for preferredFrameSize unless width and height are ASDimensionUnitPoints

* Better comment for preferredFrameSize and remove lock in calculateSizeThatFits:
2016-09-27 16:07:36 -04:00
Benjamin Scholtysik (Reimold)
8f51d1debb Merge pull request #347 from bitstadium/fix/anonymize-all-user-paths
Fix path anonymisation for binaries.
2016-09-27 09:44:16 -07:00
Scott Goodson
e8f01f082a Re-enable examples on Travis because they've now been updated for new layout API. 2016-09-26 21:28:24 -07:00