Commit Graph

25012 Commits

Author SHA1 Message Date
appleguy
4364468729 Revert Xcode Project file to before Cocoapods or Xcode 8 changes (seen in https://github.com/facebook/AsyncDisplayKit/pull/2295) (#2307) 2016-09-26 19:43:59 -07:00
appleguy
fc09badf94 Update build script to run against iOS 10 to fix Jenkins (#2305)
* Update build script to run against iOS 10 to fix Jenkins

* Update Swift example project with iOS 10 build fixes.

* Fix Videos example app to use new style API for layout properties.

* Update Frameworks smoke test to newer Swift language settings.
2016-09-26 18:46:22 -07:00
Garrett Moon
d909a8af01 I don't believe it's safe to return a vector by reference created in a function. (#2286) 2016-09-26 17:41:58 -04:00
Adlai Holler
29dd3ce6d6 [build.sh] Update Build Scripts to Get CI Working (#2272)
* [build.sh] Specify iOS 10 SDK for Xcode 8 compatibility

* Update .travis.yml to align with Jenkins config

* Disable examples during API updates
2016-09-26 12:25:10 -07:00
Benjamin Scholtysik (Reimold)
c0f780dd5b Update readme with paragraph about custom measurements and properties 2016-09-26 10:59:47 -07:00
Peter
c88865b71c Merge commit '952688d02c4603ce96e148e77dfe0946dfaa91db' 2016-09-26 15:29:50 +03:00
Peter
10d97e83ec no message 2016-09-26 15:29:44 +03:00
Hannah Troisi
679f68e169 upgrade snaphot tests to support IOS 10 (#2295) 2016-09-25 20:53:27 -07:00
Adlai Holler
4326fc90bf Pass the cell node through in willDisplay: table/collection callbacks (#2282) 2016-09-23 19:50:53 -04:00
Hannah Troisi
b18e1bc071 Fix example projects to use Layout API 2.0 style object (#2285)
* fix examples/ASDKLayoutTransition

* fix examples/ASMapNode to use new Layout API 2.0

* fix examples/SocialAppLayout to use Layout API 2.0

* fix CatDealsCollectionView to use Layout API 2.0

* fix examples/AsyncDisplayKitOverview to use Layout API 2.0

* Kittens Layout API 2.0 fixes

* HorizontalWithinVerticalScrolling

* VerticalWithinHorizontalScrolling

* ASDKTube

* fix ASViewController

* fix layout

* fix layout

* fix size
2016-09-23 16:24:21 -07:00
Adlai Holler
ce1d21dc63 [ASCellNode] Document cell node event callback behavior for plain-node cases (#2281) 2016-09-23 13:30:30 -04:00
Michael Schneider
9f55de2c6c Remove styleClass property from ASLayoutable for now (#2279) 2016-09-23 09:30:17 -07:00
Michael Schneider
75dca556e6 [Layout] Add style property to ASLayoutable (#2261)
* Add style property to ASLayoutable

* Add styles property to further layout specs

* Adjust some examples

* Add `loadStyle` to create the style object in a ASLayoutable

* Revert "Add `loadStyle` to create the style object in a ASLayoutable"

This reverts commit 2b7240f2c7dc993e38cadf290cfdf08482dd70c7.

* Revert "Adjust some examples"

This reverts commit 3254ae0a321e75db3ecfa80adee9d96bde93a33d.

* Revert "Add styles property to further layout specs"

This reverts commit c779dcb876ead27122c1af1300146a6ad36912cb.

* Rename ASLayoutableStyleDeclaration to ASLayoutableStyle

* Add styleClass class property for extensibility support of the ASLayoutable style object

* flexShrink should not be YES by default
2016-09-22 16:00:52 -07:00
Michael Schneider
a9857f9963 Add assertions for creating an invalid ASDimension from type ASDimensionUnitAuto and ASDimensionUnitFraction (#2268) 2016-09-22 15:48:36 -07:00
Brandon Withrow
c8de118fbd Merge pull request #2 from brandon-withrow/btw/animatedProgress
Fix Bug with animated Progress
2016-09-22 14:42:47 -07:00
Brandon Withrow
13f5639180 Fix Bug with animated Progress 2016-09-22 14:41:49 -07:00
Michael Schneider
9f1a387ba0 [ASTableView / ASCollectionView] Improve assertion messages if necessary data source methods are not implemented (#2269)
* Improve assertion message if tableView:nodeBlockForRowAtIndexPath: or tableView:nodeForRowAtIndexPath: is not implemented

* Improve assertion message if collectionView:nodeForItemAtIndexPath: or collectionView:nodeBlockForItemAtIndexPath: is not implemented
2016-09-22 13:35:04 -07:00
Benjamin Scholtysik (Reimold)
f169cc9112 Update unit test and some renaming 2016-09-21 15:18:03 -07:00
Benjamin Scholtysik (Reimold)
5ccffdba79 Merge pull request #345 from bitstadium/feature/config
Configuration updates
2016-09-21 14:37:43 -07:00
Benjamin Scholtysik (Reimold)
b5f0379e14 Fix path anonymisation for binaries. 2016-09-21 14:36:37 -07:00
Michael Schneider
8427083ddb Set default value of flexShrink to NO (#2270) 2016-09-21 13:17:35 -07:00
Rocir Santiago
7dd997d442 Minor tweaks around image alignment in ASButtonNode (#2271) 2016-09-20 19:47:13 -04:00
Harry Shamansky
71fc2dd18d Revise performance measurement naming and structure (#2265)
* Revise performance measurement naming and structure

- Revises naming from LayoutSpecGeneration to LayoutSpecComputation
- Adds a struct instead of an NSDictionary to retrieve performance metrics
- Includes ASEnvironmentStatePropagateDown in LayoutSpecComputation measurements

* Revise SumScopeTimer to include enable flag

* Make struct a typedef
2016-09-20 15:39:09 -04:00
Benjamin Scholtysik (Reimold)
598c334c7c Merge pull request #342 from bitstadium/feature/add-swift3-setup-code
Add some swift 3 setup sample code
2016-09-20 09:11:16 -07:00
Lukas Spieß
3cd536ddaf Rename ReleaseDefault config to Release 2016-09-20 15:16:36 +02:00
Lukas Spieß
234f7c7ed4 Update build config to build with Bitcode on iOS 10 Base SDK 2016-09-20 13:30:17 +02:00
Rocir Santiago
5990376f68 Add support to image alignment in ASButtonNode (#2266) 2016-09-19 17:16:49 -07:00
appleguy
3e5b8c3096 [ASDisplayNode] Ensure ASHierarchyState propagation does not jump discontinuities in the node hierarchy. (#2263)
Scenario: An ASCollectionNode is a subnode of an ASCellNode.  A layout transition is started, resulting in
the removal of the ASCollectionNode as a subnode.  As it is removed, the hierarchy state is cleared - including
the "range managed" bit - on the ASCollectionNode.  However, the deep recursion traverses the layer hierarchy
too, and clears this bit on the ASCellNodes inside the ASCollectionNode.  A moment later, the collection performs
its final ASRangeController update to mark its cells as invisible and free memory.  Then an assertion is triggered
in ASRangeController, because it is operating on nodes that do not have the "range managed" bit set.

It turns out that ASInterfaceState also propogates in this way, but that behavior is efficient and beneficial in
its current configuration (it assists how multi-dimensional preloading works).  However, hierarchy state should
never need to jump discontinuities in the node hierarchy.  For now, disabling that case and will revisit
other use cases soon.
2016-09-19 12:04:39 -07:00
Adlai Holler
48f76c40d5 Fix ASViewController accessing traitCollection on iOS 7 (#2259) 2016-09-16 08:52:09 -07:00
Benjamin Scholtysik (Reimold)
54b1eec73d Merge pull request #336 from bitstadium/feature/remove-linkage-to-asset-library-from-default-config
removing unnecessary linking and add comment to all features xcconfig
2016-09-16 08:39:23 -07:00
Benjamin Scholtysik (Reimold)
0cbd22e2c5 Merge pull request #334 from bitstadium/master
Master
2016-09-16 08:38:52 -07:00
Adlai Holler
25de53bb13 [ASDisplayNode] Add Event Tracing to Help Debugging (#2243)
* Add some simple event logging for ASDisplayNode

Improve the tracing

* Add header to copy files phase

* Make event header public
2016-09-15 13:24:19 -07:00
Adlai Holler
8459c1e825 Remove some thread affinity assertions that we no longer need (#2251) 2016-09-15 12:13:24 -07:00
Adlai Holler
1e86dcdbe2 [ASDisplayNode] Use kCGBlendModeCopy in a Couple More Places (#2250)
* Use blend mode copy in a couple more places

* Add some tests
2016-09-15 11:56:46 -07:00
Benjamin Scholtysik (Reimold)
412659c80b Add some swift 3 setup sample code 2016-09-15 11:33:55 -07:00
Adlai Holler
88d588d590 [ASDisplayNode] Use Weak Proxy to Avoid Dangling CALayer.delegate (#2249)
* Add weak proxy between node and layer to avoid dangling layer problem

* Add failing test case for dangling CALayer.delegate pointer issue

* Add docs

* Remove asynctransactioncontainer forwarding preprocessor macro

* Improve comments

* Remove asyncTransactionContainerStateDidChange callback
2016-09-15 10:49:31 -07:00
Adlai Holler
4cf571c830 [ASCollectionView] Add Support for Interactive Reordering (#2221)
[ASTableView] Add Support for Interactive Reordering
2016-09-14 22:31:04 -07:00
Adlai Holler
d1d25a770c Don't beginUpdates/endUpdates on cell relayout if data source is gone (#2248) 2016-09-14 16:21:05 -07:00
Adlai Holler
c7b290e4cb Fix snapshot unit test merge issue 2016-09-14 11:31:45 -07:00
Adlai Holler
bba71d05f0 Set .flexShrink to YES by default (#2247)
To align with the CSS flex-shrink spec, set the default value of flexShrink to YES: http://www.w3.org/TR/css-flexbox-1/#propdef-flex-shrink
2016-09-14 11:24:24 -07:00
Benjamin Scholtysik (Reimold)
3305675a87 Merge pull request #335 from bitstadium/feature/update-setup-template
Just updating the setup-template
2016-09-14 10:37:08 -07:00
Thibault Leruitte
8d639cc5f2 Check if update alert should be shown with update manager delegate 2016-09-14 16:52:26 +02:00
gazreese
025af5d594 [ASVideoNode] Maintain playback position between visibility changes (#2120)
* [ASVideoNode] Maintain playback position between visibility changes

* [ASVideoNode] Code style changes and moved the pause to be before caching the current playback time.
2016-09-13 20:44:26 -07:00
Adlai Holler
337e908390 Make Description Functions Dealloc-Safe (#2241)
* Make description functions dealloc-safe

* Make -debugDescription also dealloc-safe
2016-09-13 17:48:31 -07:00
Benjamin Scholtysik (Reimold)
8e4ba2508d Merge remote-tracking branch 'origin/master' into feature/update-setup-template 2016-09-13 15:34:25 -07:00
Benjamin Scholtysik (Reimold)
737f6c8911 Merge pull request #337 from bitstadium/feature/small-readme-fixes
a tiny tiny fix to the readme
2016-09-13 15:33:04 -07:00
Benjamin Scholtysik (Reimold)
b8cdbe9ebd a tiny tiny fix to the readme 2016-09-13 15:31:32 -07:00
Benjamin Scholtysik (Reimold)
03248d9b24 removing unnecessary linking and add comment to all features xcconfig 2016-09-13 15:14:45 -07:00
Benjamin Scholtysik (Reimold)
55d36c0ff6 Just updating the setup-template 2016-09-13 14:57:01 -07:00
Benjamin Scholtysik (Reimold)
273495df27 Merge pull request #333 from bitstadium/release/4.1.1
Release/4.1.1
2016-09-13 14:24:58 -07:00