Commit Graph

25012 Commits

Author SHA1 Message Date
Benjamin Scholtysik (Reimold)
793f0e5972 Merge remote-tracking branch 'origin/master' into release/4.1.1
# Conflicts:
#	README.md
2016-09-13 09:14:00 -07:00
Lukas Spieß
f42c714cb0 Update Changelog with 4.1.1 changes 2016-09-13 13:29:00 +02:00
Lukas Spieß
664bb00f53 Merge pull request #331 from bitstadium/feature/feedback-module
Feature/feedback module
2016-09-13 13:27:49 +02:00
Lukas Spieß
a6f28d8465 Merge pull request #332 from bitstadium/feature/prefix-vars-to-avoid-collisions
Rename properties of BITCrashMetaData to avoid namespace collisions.
2016-09-13 13:11:31 +02:00
Benjamin Scholtysik (Reimold)
31afd36dcf Rename property of BITCrashMetaData to avoid namespace collisions. 2016-09-12 15:12:20 -07:00
Lukas Spieß
ef507c9780 Rename default subspec 2016-09-12 22:22:54 +02:00
Benjamin Scholtysik (Reimold)
6e38dbfe37 Merge branch 'feature/feedback-module' of https://github.com/bitstadium/HockeySDK-iOS into feature/feedback-module
# Conflicts:
#	Classes/BITAttributedLabel.m
2016-09-12 12:07:09 -07:00
Lukas Spieß
7aa862b3a3 Consolidate release configurations 2016-09-12 12:04:57 -07:00
Benjamin Scholtysik (Reimold)
b2bfd25553 Updating the readme with new feedback info 2016-09-12 12:04:57 -07:00
Benjamin Scholtysik (Reimold)
d686ea3156 Update podspec to use NoFeedbackLib-subspec 2016-09-12 12:04:57 -07:00
Benjamin Scholtysik (Reimold)
16ee4273e6 Clean up the xcconfig files 2016-09-12 12:04:57 -07:00
Benjamin Scholtysik (Reimold)
5fbbe507e1 Adding PREPROCESSOR_DEFINITIONS back to nofeedback.xcconfig so the nofeedback-config actually works 2016-09-12 12:04:57 -07:00
Benjamin Scholtysik (Reimold)
34eda29ddb Make sure modulemap-files are always copied as module.modulemap, otherwise using the SDK won’t work. 2016-09-12 12:04:57 -07:00
Benjamin Scholtysik (Reimold)
4739872aa9 rename release.xcconfig to nofeedback.xcconfig to make more clear what it is 2016-09-12 12:04:57 -07:00
Benjamin Scholtysik (Reimold)
ce06e1609e Remove Feedback feature from hockey config 2016-09-12 12:04:57 -07:00
Benjamin Scholtysik (Reimold)
f69f6455be Add configuration for full feature set 2016-09-12 12:04:56 -07:00
Lukas Spieß
ece32a7c62 Ignore pointer-bool-conversion warning in BITAttributedLabel 2016-09-12 21:04:22 +02:00
Lukas Spieß
b7ce05e3f4 Merge pull request #323 from bitstadium/feature/xcode8-beta6
Feature/xcode8 beta6
2016-09-12 20:27:10 +02:00
Adlai Holler
84e633137b [Layout] Use _addSubnode / _removeFromSupernode methods in _ASDisplayView 2 (#2232)
* Use `_addSubnode` / `_removeFromSupernode` methods in _ASDisplayView

* Change name
2016-09-12 10:46:43 -07:00
Adlai Holler
8c380d1601 Don't crash in production on invalid subnode insert (#2231) 2016-09-12 10:29:31 -07:00
Lukas Spieß
1f2fec4a54 Consolidate release configurations 2016-09-12 18:25:53 +02:00
Lukas Spieß
7eba72c4b5 Use Xcode 7.2 to work around stdout bug
Otherwise the Travis CI build fails due to the documentation generation outputting to stderr instead of stdout for something that's actually not an error
2016-09-12 16:28:06 +02:00
Benjamin Scholtysik (Reimold)
f0d04aeb2e Updating the readme with new feedback info 2016-09-11 20:06:58 -07:00
Benjamin Scholtysik (Reimold)
5897a20b70 supress warning in BITAttributedLabel 2016-09-11 18:56:14 -07:00
Benjamin Scholtysik (Reimold)
248db125ed Update podspec to use NoFeedbackLib-subspec 2016-09-11 18:44:37 -07:00
Benjamin Scholtysik (Reimold)
554ac27295 Clean up the xcconfig files 2016-09-11 18:38:43 -07:00
Benjamin Scholtysik (Reimold)
b7895f2c32 Adding PREPROCESSOR_DEFINITIONS back to nofeedback.xcconfig so the nofeedback-config actually works 2016-09-11 18:27:14 -07:00
Benjamin Scholtysik (Reimold)
ef21c99493 Make sure modulemap-files are always copied as module.modulemap, otherwise using the SDK won’t work. 2016-09-11 17:19:56 -07:00
Benjamin Scholtysik (Reimold)
382208b015 rename release.xcconfig to nofeedback.xcconfig to make more clear what it is 2016-09-11 15:03:40 -07:00
Benjamin Scholtysik (Reimold)
00d586c8e9 Remove Feedback feature from hockey config 2016-09-11 14:49:30 -07:00
Benjamin Scholtysik (Reimold)
ed71c3bebe Add configuration for full feature set 2016-09-11 13:51:33 -07:00
Peter
cb5a81670d no message 2016-09-10 18:00:50 +03:00
Harry Shamansky
59fbfb682d Measure performance for ASCellNode layout (#2209)
* Measure performance for ASCellNode layout

* Address Adlai and Levi's feedback:
* Move to ASDisplayNode level
* Lock around setting/getting measurement options and results
* Record all measurement passes and report times as an array
* Only add relevant entries to the performanceMetrics dictionary
* Rebase

* Store sum and count instead of array

* Rename ScopeTimerDataPoint to ScopeTimerSum

* Address Levi's feedback

* Address Adlai's feedback
2016-09-09 10:38:13 -07:00
Benjamin Scholtysik (Reimold)
c0813757c3 Merge pull request #329 from bitstadium/feature/add-text-about-iOS-submission
Add paragraph about missing NSPhotoLibraryUsageDescription
2016-09-08 18:10:43 -07:00
Benjamin Scholtysik (Reimold)
5229a6c2f0 Add missing #import "BITHockeyLogger.h" 2016-09-08 17:45:15 -07:00
Benjamin Scholtysik (Reimold)
4bc00fd960 Add paragraph about missing NSPhotoLibraryUsageDescription 2016-09-08 17:39:03 -07:00
John Engelhart
8c2f3f666f Fixes unsafe use of asyncdisplaykit_node. (#2207)
The previous code used either a `@property` with `assign, nonatomic` semantics, or a `__unsafe_unretained` (non-atomic) ivar pointer to an instance for `asyncdisplaykit_node`.

This commit changes those access so that they have the equivalent of `weak, atomic` semantics.

- `_ASDisplayView.mm`
  - Removes the `_node` ivar that was qualified with `__unsafe_unretained`.
  - Removes `@synthesize asyncdisplaykit_node = _node;`.
  - All direct uses of `_node` were replaced with:
    - Creates a strong reference via `ASDisplayNode *node = _asyncdisplaykit_node;`.
    - `s/_node/node/`.
    - These changes were made even if there's a single use of `_asyncdisplaykit_node` as a consistency / defensive measure so that anyone editing this code in the future does not accidentally use a `weak` reference twice.

- `ASDisplayNode.mm`
  - Getters and setters for `asyncdisplaykit_node` were changed from `nonatomic, assign` semantics to the equivalent of `atomic, weak` semantics.
  - `weak` semantics were implemented by using a `ASWeakProxy` object.
  - `objc_setAssociatedObject` was changed from `OBJC_ASSOCIATION_ASSIGN` to `OBJC_ASSOCIATION_RETAIN` (the `atomic` version of retain).

- `ASDisplayNode+FrameworkPrivate.h`
  - Changed the `@property` declarations for `asyncdisplaykit_node` from `nonatomic, assign` to `atomic, weak`.
    - The actual getters and setters are implemented in `ASDisplayNode.mm`, which were changed accordingly.
2016-09-08 17:27:49 -07:00
ricky
6bef1e129a [ASViewController] fix layout recursion (#2218)
I don’t think this `setNeedsLayout` is required since we call `measure` now.
2016-09-08 16:01:14 -07:00
Adlai Holler
0d3b31dc2d Fix tests that failed due to merging an old PR (#2217) 2016-09-08 14:37:53 -07:00
Adlai Holler
85fee6b609 Fix the dealloc test (#2216) 2016-09-08 14:25:00 -07:00
Adlai Holler
bc59b96ca9 [ASDisplayNode] Add onDidLoad Method to Perform Work When Loaded (#2128)
* [ASDisplayNode] Add `onDidLoad:` method

* Prevent user from rasterizing wrapper nodes – they can't be reloaded in the future
2016-09-08 14:18:35 -07:00
Hannah Troisi
593f13d800 Improve crash logging [@johnepinterest] (#2210) 2016-09-08 14:06:49 -07:00
Benjamin Scholtysik (Reimold)
525a98eb18 Switch back to Xcode 7.3 for travic ci 2016-09-08 14:06:39 -07:00
Benjamin Scholtysik (Reimold)
9011912213 Replace NSLog with BITHockeyLogger calls 2016-09-08 14:02:14 -07:00
Adlai Holler
12ab2e3759 Fix equality in ASTextKitRendererKey (#2215) 2016-09-08 12:59:03 -07:00
Michael Schneider
0d8518912e Initial commit to throw an exception if manually adding / removing subnodes if node has automaticallyManagesSubnodes enabled (#2214) 2016-09-08 11:59:57 -07:00
Benjamin Scholtysik (Reimold)
311bb8f454 Remove two asserts that don’t make much sense and cause a crash in iOS 10 simulators. 2016-09-08 11:53:57 -07:00
Michael Schneider
53a6743908 Don't use automaticallyManageSubnodes in ASTextCellNode (#2212) 2016-09-08 11:17:50 -07:00
Adlai Holler
5593bfa4d1 [ASDisplayNode] Majorly Improve Descriptions (#2208)
* Up our description game big time

* Couple tweaks

* Explain logic

* Fix indentation
2016-09-07 20:11:27 -07:00
Benjamin Scholtysik (Reimold)
66a33c04cc Fix yml for travis CI 2016-09-07 17:20:12 -07:00